Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebNN EP] Remove NHWC preferred layout #21570

Merged
merged 1 commit into from
Aug 28, 2024
Merged

[WebNN EP] Remove NHWC preferred layout #21570

merged 1 commit into from
Aug 28, 2024

Conversation

Honry
Copy link
Contributor

@Honry Honry commented Jul 31, 2024

Currently WebNN CPU backend has supported NCHW layout in Chromium, we can now drop NHWC preferred layout for CPU backend in WebNN EP to simplify the code.

@Honry
[WebNN EP] Remove NHWC preferred layout
642d030 
Currently WebNN CPU backend has supported NCHW layout in Chromium,
we can now drop NHWC preferred layout for CPU backend in WebNN EP
to simplify the code.
@Honry
Copy link
Contributor Author

Honry commented Aug 2, 2024

@fdwr, @guschmue, PTAL, thanks!

cc/ @huningxin, @fujunwei

@fdwr fdwr self-requested a review August 2, 2024 21:40
@fdwr fdwr added the ep:WebNN WebNN execution provider label Aug 2, 2024
fdwr
fdwr approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Red is my favorite color in code reviews.

onnxruntime/core/providers/webnn/builders/impl/conv_op_builder.cc Show resolved Hide resolved
@fdwr
Copy link
Contributor

fdwr commented Aug 2, 2024

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Aug 2, 2024

/azp run Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Linux Android Emulator QNN CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Aug 2, 2024

/azp run Android CI Pipeline,iOS CI Pipeline,ONNX Runtime React Native CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 10 pipeline(s).

@fdwr
Copy link
Contributor

fdwr commented Aug 5, 2024

/azp run Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@guschmue
Copy link
Contributor

guschmue commented Aug 6, 2024

/azp run ONNX Runtime React Native CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-amd-gpu-ci-pipeline (Linux_Build_manylinux)

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@guschmue
Copy link
Contributor

/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@guschmue guschmue merged commit 5911422 into microsoft:main Aug 28, 2024
83 of 85 checks passed
Honry added a commit to Honry/onnxruntime that referenced this pull request Aug 29, 2024
@Honry
Revert "[WebNN EP] Remove NHWC preferred layout (microsoft#21570)"
1e10c1e 
This reverts commit 5911422.
@Honry Honry mentioned this pull request Aug 29, 2024
Merged
fdwr pushed a commit that referenced this pull request Aug 30, 2024
@Honry
Revert "[WebNN EP] Remove NHWC preferred layout" (#21905)
7550fec 
Reverts #21570
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdwr fdwr fdwr approved these changes

@huningxin huningxin huningxin left review comments

@reillyeon reillyeon reillyeon left review comments

@guschmue guschmue guschmue approved these changes

Assignees
No one assigned
Labels
ep:WebNN WebNN execution provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Honry @fdwr @guschmue @reillyeon @huningxin